Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make computation for breakpoints in ResizeObserver async. #674

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

cjpillsbury
Copy link
Collaborator

Ensures we do not end up with loop limit exceeded RTEs when breakpoints computations take too long.

@cjpillsbury cjpillsbury requested review from a team and heff as code owners June 23, 2023 19:01
@vercel
Copy link

vercel bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 7:52pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 7:52pm

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #674 (e95aa5c) into main (6e17284) will increase coverage by 0.02%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   78.39%   78.41%   +0.02%     
==========================================
  Files          43       43              
  Lines        8184     8201      +17     
==========================================
+ Hits         6416     6431      +15     
- Misses       1768     1770       +2     
Impacted Files Coverage Δ
src/js/utils/server-safe-globals.js 93.90% <66.66%> (-2.21%) ⬇️
src/js/media-container.js 82.15% <100.00%> (+0.38%) ⬆️

@cjpillsbury cjpillsbury merged commit d311472 into muxinc:main Jun 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants