Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use queueMicrotask for async ResizeObserver cb. #677

Merged

Conversation

cjpillsbury
Copy link
Collaborator

No description provided.

@cjpillsbury cjpillsbury requested review from a team and heff as code owners June 29, 2023 14:42
@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 2:43pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 2:43pm

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #677 (bff421f) into main (d311472) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   78.41%   78.44%   +0.02%     
==========================================
  Files          43       43              
  Lines        8201     8206       +5     
==========================================
+ Hits         6431     6437       +6     
+ Misses       1770     1769       -1     
Impacted Files Coverage Δ
src/js/media-container.js 82.18% <100.00%> (+0.03%) ⬆️
src/js/utils/server-safe-globals.js 95.34% <100.00%> (+1.44%) ⬆️

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjpillsbury cjpillsbury merged commit e9be608 into muxinc:main Jun 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants