Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use setTimeout at ~=1 frame (16ms) since queueMicrotask may stil… #682

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

cjpillsbury
Copy link
Collaborator

…l execute multiple times per animation frame.

…l execute multiple times per animation frame.
@cjpillsbury cjpillsbury requested review from a team and heff as code owners July 5, 2023 15:55
@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 3:56pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 3:56pm

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #682 (2d42e2b) into main (44922fb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage   78.44%   78.44%           
=======================================
  Files          43       43           
  Lines        8206     8206           
=======================================
  Hits         6437     6437           
  Misses       1769     1769           
Impacted Files Coverage Δ
src/js/media-container.js 82.18% <100.00%> (ø)

@cjpillsbury cjpillsbury merged commit 93ff3cb into muxinc:main Jul 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants