fix(iroh-blobs): Remove debugging logs & more cleanup #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2690/docs/iroh/ Last updated: 2024-09-02T16:01:23Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More stuff to clean up I came across while trying to debug an issue.
Also, this makes it so that errors from
iroh_blobs::get::db::get_blobthat happen before theget_connstep get printed.Breaking Changes
None.
Notes & open questions
I decided to just remove the tracing logs in
downloader/progress.rs. They never really helped us surface the bug, they mostly polluted the logs, to be honest.The only thing they surfaced was that we didn't properly clean up
TransferState::progress_id_to_blobwhen there's an error iniroh_blobs::get::db::get_blobthat causes us to not send theDownloadProgress::Doneevent.Change checklist