Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix the errors that are failing CircleCI tests #417

Draft
wants to merge 2 commits into
base: v4
Choose a base branch
from

Conversation

Jamiewarb
Copy link

@Jamiewarb Jamiewarb commented Oct 24, 2021

The CircleCI tests are failing in at least 3 places:yarn lint, yarn test and tsc.

Linting

CircleCI build is failing from a tiny linter error. This fixes it

$ yarn lint

/home/circleci/project/test/fixture-local-state/plugins/apollo-config.js
  20:18  error  Expected parentheses around arrow function argument having a body with curly braces  arrow-parens

Jest

With the linter error fixed, the next step yarn test is now running and showing errors.
It looks like the reason for these errors is that the API the tests are hitting is down.

I'm not sure if this API will come back or not. For the meantime, I've adapted the code to use a different graphql endpoint.

We may want to look at creating a mock graphql endpoint to remove the flake from the tests

tsc

NOTE: Looking in to this now

@Jamiewarb Jamiewarb marked this pull request as draft October 24, 2021 21:04
@Jamiewarb Jamiewarb changed the title fix(test): fix the linter error that is failing CircleCI tests fix(test): fix the errors that are failing CircleCI tests Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant