Make OC edit warning modal cancel button redirect user to OC list [OFN-12774]

[wandji20]

What? Why?

• Closes [Admin] [Order cycles] Cancel button of popup should redirect to OC list #12774

Make OC edit warning modal cancel button redirect the user to OC list

What should we test?

Verify that the cancel button in the edit OC warning modal links to the OC list.

• Visit ... page.
  /admin/order_cycles/2/edit

Release notes

Order cycle warning modal cancel link redirects the user to Order cycle list

Changelog Category (reviewers may add a label for the release notes):

• User facing changes

Order cycle warning modal cancel link redirects the user to Order cycle list

Dependencies

N/A

Documentation updates

N/A

[rioug]

Looks good, thanks @wandji20 🙏

[filipefurtad0]

This PR is conflicting with your other (just merged PR), it needs a rebase and conflict fix before testing. Thanks @wandji20 🙏

[drummer83]

Hi @wandji20,
Thanks for fixing this last bit. 💪

I couldn't find any problems. Clicking cancel redirects to the order cycle list as expected now. There is an additional popup from the browser now. Is there anything we can do about that?

Kazam_screencast_00021.webm

Also Github is asking for another review. Do we need that or is it just due to the earlier conflict resolution?

Let me know and I will move this forward.
Thanks again!

[wandji20]

Hello @drummer83
I'm sorry for not getting back to you sooner, and
thanks for testing this one.

There is an additional popup from the browser now

It will seem we now block page exit if the order cycle form has unsaved changes.
However, this is new to me and I think some changes were made after I opened PR.
I will see if that's the case a find a suitable workaround

is it just due to the earlier conflict resolution?

Yes

[mkllnk]

Cool, this could work.