CB improvements #769
Open
CB improvements #769
+336
−359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-lavrenov
commented
Aug 13, 2024
| auto running_sequences = sequence_group->get_running_sequences(); | ||
| // TODO: ilavrenov - why beam search case is not handled here? | ||
| // in case of beam search 'blocks_num' are not equally distributed between sequences | ||
| // because some of them share the same blocks |
| // preempt prompt fully to not leave partially generated prompt | ||
| preempted_tokens = processed_tokens; | ||
| preempted_tokens = context_len; | ||
| // TODO: ilavrenov - what is we have multiple sequences within a group? we need to drop them all |
mzegla
reviewed
Aug 14, 2024
Comment on lines
+58
to
+59
| // token by token. This structure represents a vector of already generated tokens so far | ||
| // for a given prompt. |
There was a problem hiding this comment.
That's not exactly true. I would rephrase that to: "... a vector of tokens generated since the last read...".
To be more specific it's always vector of one element if N == 1 and we are not using beam search.
For N > 1 and/or beam search is used vector contains all generated tokens.
| using GenerationOutputs = std::unordered_map<uint64_t, GenerationOutput>; | ||
|
|
||
| class GenerationStream; | ||
|
|
||
| class OPENVINO_GENAI_EXPORTS GenerationHandleImpl { | ||
| class OPENVINO_GENAI_EXPORTS GenerationHandle { |
There was a problem hiding this comment.
Why do we need this change?
| std::shared_ptr<GenerationStream> m_generation_stream; | ||
| ov::genai::GenerationConfig m_sampling_params; | ||
|
|
||
| bool is_dropped(); | ||
| // whether client ha dropped session with pipeline |
There was a problem hiding this comment.
Suggested change
| // whether client ha dropped session with pipeline | |
| // whether client has dropped session with pipeline |
|
|
||
| bool can_read(); | ||
| // whether new tokens are available |
There was a problem hiding this comment.
Suggested change
| // whether new tokens are available | |
| // whether read() is possible (new tokens are available and handle has not been dropped) |
Comment on lines
25
to
+30
| // whether to split prompt / generate to different scheduling phases | ||
| // - Dynamic split fuse schdules requests in generation phase first, then | ||
| // schdules requests in prompt phase. If request cannot be fully fit into | ||
| // remaining space of 'max_num_batched_tokens' group, it's scheduled only partially | ||
| // and other tokens can be scheduled only next iterations | ||
| // - vLLM mode priorities requests in prompt phase over requests on generation phase |
There was a problem hiding this comment.
Suggested change
| // whether to split prompt / generate to different scheduling phases | |
| // - Dynamic split fuse schdules requests in generation phase first, then | |
| // schdules requests in prompt phase. If request cannot be fully fit into | |
| // remaining space of 'max_num_batched_tokens' group, it's scheduled only partially | |
| // and other tokens can be scheduled only next iterations | |
| // - vLLM mode priorities requests in prompt phase over requests on generation phase | |
| // whether to split prompt / generate to different scheduling phases | |
| // - Dynamic split fuse schedules requests in generation phase first, then | |
| // schedules requests in prompt phase. If request cannot be fully fit into | |
| // remaining space of 'max_num_batched_tokens' group, it's scheduled only partially | |
| // and other tokens can be scheduled in next iterations | |
| // - vLLM mode prioritizes requests in prompt phase over requests in generation phase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.