modifying guppy css for guppy migration to package.json #4
Conversation
|
@shivkant5 Why haven't any reviewers been assigned for this PR? |
I dont know why there are no reviewers on this PR (might be because this is the forked repo of guppy package). I am also not able to assign someone on this PR. |
|
@seanlip PTAL |
| @@ -50,7 +50,7 @@ | |||
| background:url('./icons/keyboard.png') center no-repeat; | |||
| } | |||
| .guppy_buttons div.help{ | |||
| background:url('./icons/help.png') center no-repeat; | |||
| background:url('/dist/oppia-angular/icons/help.png') center no-repeat; | |||
There was a problem hiding this comment.
As discussed, I don't think guppy should depend on impl details of oppia. The dependency should be one-way from Oppia to Guppy.
Please find a way to make this change within Oppia instead (e.g. using a more specific CSS rule to override this one (preferred), or in the worst case, using TS to modify the CSS). If you want to modify this fork, then the changes need to be general, otherwise it will become hard to maintain and understand.
There need to be some minor CSS fixes for some icons that aren't displayed after migrating guppy to package.json. help icon was not displayed due to some conflicts with webpack, so accordingly CSS needs to be fixed. This PR must be merged after fixing other configs for this package in PR#18742, so that the package works fine
Screencast.from.05-08-23.06.47.46.PM.IST.webm