-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transformer): async-to-generator
plugin.
#5590
base: main
Are you sure you want to change the base?
feat(transformer): async-to-generator
plugin.
#5590
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
136bfbc
to
aad667e
Compare
CodSpeed Performance ReportMerging #5590 will degrade performances by 89.96%Comparing Summary
Benchmarks breakdown
|
It appears that the iteration of the ast tree incurs performance degradation. However, it necessitates the duplication of statements for replacement. Are there alternative approaches that could be considered? |
45a0ff9
to
3d069a3
Compare
@7086cmd Can you hold onto this and let us take a look first? We may end up implementing this differently with architectural changes. |
Ok. It does need some refactor, especially when it comes some polyfills here, we'd better do as what babel does: from js text to ast, which is visually more vibrant and more convenient. Replacing to multiple statements is also a handful problem. |
For this PR, I would prefer what |
Tests are still not passed. A lot need to do yet.