Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated eslint devDepencencies #1306

Draft
wants to merge 105 commits into
base: dev
Choose a base branch
from

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Mar 28, 2021

Summary of changes:

It's important that someone else with ESLint, babel and webpack knowledge would have a look at these changes, especially my three code comments and the necessary evaluations.

  • Updated all eslint and related dependencies to newer versions and
  • extracted the eslintconfig within the live-server package to an external config file

added

  • eslint-plugin-node:
    • Two of the previously introduced eslint rules have been moved to this plugin by ESLint v7.0.0:
      • no-mixed-requires -> node/no-mixed-requires
      • no-process-exit -> node/no-process-exit
  • @babel/eslint-plugin

    Companion rules for @babel/eslint-parser. @babel/eslint-parser does a great job at adapting eslint for use with Babel, but it can't change the built-in rules to support experimental features. @babel/eslint-plugin re-implements problematic rules so they do not give false positives or negatives.

updated dependencies

replaced

Changed

rules
extends
ESLint and babel configs

sub-packages ESLint config file with an extend to root isn't necessary, as ESLint would search for that config anyhow, but we need to reference the root babel.config.js in our monorepo, compare to e.g.
https://babeljs.io/docs/en/config-files#root-babelconfigjson-file and https://babeljs.io/docs/en/config-files#file-relative-configuration

pending

  • Why do we have both a .eslintrc.js and a .eslintrc.json in the root?

#updatingdependenciesbitbybitbybitbybitbybitbybitbybitbybit

mfranzke and others added 27 commits April 24, 2020 16:56
missed to replace mustache initially and incorrect handlebars two times (both in package name and URL)
This reverts commit 7812878, reversing
changes made to 26db979.
This reverts commit 26db979, reversing
changes made to fc90750.
@mfranzke mfranzke changed the title refactor: updated eslint depencencies refactor: updated eslint (dev)Depencencies Dec 16, 2021
@mfranzke mfranzke changed the title refactor: updated eslint (dev)Depencencies refactor: updated eslint devDepencencies Dec 16, 2021
@mfranzke mfranzke added the dependencies Pull requests that update a dependency file label Dec 27, 2021
@@ -36,30 +36,6 @@ const server = (patternlab) => {
patternlab.config.paths.public.root
)
);
defaults.assets = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is an old PR which is still WIP, but could you elaborate why this gets removed when the PR only is about ESLint changes?

@@ -27,7 +27,6 @@ function serve() {
return patternlab.server
.serve({
cleanPublic: config.cleanPublic,
watch: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for the removal of this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants