Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added dib extension for C# #325

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

WhiteBlackGoose
Copy link
Contributor

@WhiteBlackGoose WhiteBlackGoose commented Jul 12, 2022

Now we can do this

image

@WhiteBlackGoose WhiteBlackGoose changed the title added dib extension for C# Added dib extension for C# Jul 12, 2022
@WhiteBlackGoose
Copy link
Contributor Author

Note: I wish I could do the same for F#, but this dotnet/interactive#1808 should be fixed before

@WhiteBlackGoose WhiteBlackGoose changed the title Added dib extension for C# [Feature] Added dib extension for C# Jul 17, 2022
@kMutagene
Copy link
Collaborator

should we maybe add this to Plotly.NET.Interactive for now (also making Plotly.NET.Interactive dependent on Plotly.NET.CSharp in the process), to have all in the same place? When this works for F# as well, we can get rid of the Interactive package alltogether and just add the .dib file to the indivisual packages.

@WhiteBlackGoose
Copy link
Contributor Author

It doesn't work if the dib file is written in F#, and it also doesn't work when F#/C# dib file is invoked from F# context. So only C# from C# works for now.

Yes, you can make Interactive dependent on Plotly.NET.CSharp instead of Plotly.NET. Both work. I personally think, that making Plotly.NET.CSharp interactive on its own is a bit better, because a bit more intuitive and less deps for interactive, but yeah, up to you.

When this works for F# as well, we can get rid of the Interactive package alltogether and just add the .dib file to the indivisual packages.

Actually, if we don't care about the size of the package, we could as well just bake everything (C#, F#, bindings) into one package (again, as soon as they fix that bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants