Improve chart grids #453
Merged
Improve chart grids #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will improve
Chart.Grid(and by extension,Chart.SingleStack) to:respect all present subplot anchors and ids of the input charts. This means that e.g. a chart with 2 Y axes will keep both in the resulting grid, with both axes set to the correct grid ___location.Not possible due to plotly.js limitations. Instead, we take the first each and remove everything else. If multiple axes per cells are needed users have to refer to creating their own ___domain-based grids
therefore, this PR
fixes #415
fixes #413
fixes #388
fixes #387