Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist depth sorting function #3834

Closed
wants to merge 1 commit into from
Closed

Conversation

marvinhagemeister
Copy link
Member

A simple test to see if this moves benchmark numbers at all.

@github-actions
Copy link

github-actions bot commented Dec 22, 2022

📊 Tachometer Benchmark Results

Summary

duration

  • 03_update10th1k_x16: unsure 🔍 -3% - +9% (-0.14ms - +0.40ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +2% (-24.35ms - +31.91ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +2% (-5.93ms - +5.45ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +12% (-3.27ms - +11.75ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -1% - +4% (-2.30ms - +6.59ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +1% (-0.19ms - +0.49ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -1% - +2% (-0.28ms - +0.83ms)
    preact-local vs preact-master

usedJSHeapSize

  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.05ms - +0.02ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -7% - +3% (-0.78ms - +0.34ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master4.44ms - 4.72ms-unsure 🔍
-8% - +3%
-0.40ms - +0.14ms
preact-local4.48ms - 4.94msunsure 🔍
-3% - +9%
-0.14ms - +0.40ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.79ms - 3.79ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.79ms - 3.79msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1973.63ms - 2012.95ms-unsure 🔍
-2% - +1%
-31.91ms - +24.35ms
preact-local1976.95ms - 2017.19msunsure 🔍
-1% - +2%
-24.35ms - +31.91ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master26.30ms - 26.36ms-unsure 🔍
-0% - +0%
-0.02ms - +0.05ms
preact-local26.29ms - 26.34msunsure 🔍
-0% - +0%
-0.05ms - +0.02ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master254.47ms - 262.79ms-unsure 🔍
-2% - +2%
-5.45ms - +5.93ms
preact-local254.50ms - 262.27msunsure 🔍
-2% - +2%
-5.93ms - +5.45ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.83ms - 1.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local1.82ms - 1.83msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master93.09ms - 103.27ms-unsure 🔍
-11% - +3%
-11.75ms - +3.27ms
preact-local96.90ms - 107.95msunsure 🔍
-3% - +12%
-3.27ms - +11.75ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master11.18ms - 11.92ms-unsure 🔍
-3% - +7%
-0.34ms - +0.78ms
preact-local10.90ms - 11.75msunsure 🔍
-7% - +3%
-0.78ms - +0.34ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master182.17ms - 187.54ms-unsure 🔍
-4% - +1%
-6.59ms - +2.30ms
preact-local183.46ms - 190.54msunsure 🔍
-1% - +4%
-2.30ms - +6.59ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master5.18ms - 5.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local5.19ms - 5.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master44.25ms - 44.67ms-unsure 🔍
-1% - +0%
-0.49ms - +0.19ms
preact-local44.35ms - 44.88msunsure 🔍
-0% - +1%
-0.19ms - +0.49ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.06ms - 1.07ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.06ms - 1.07msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
todo

duration

VersionAvg timevs preact-mastervs preact-local
preact-master42.07ms - 42.63ms-unsure 🔍
-2% - +1%
-0.83ms - +0.28ms
preact-local42.14ms - 43.11msunsure 🔍
-1% - +2%
-0.28ms - +0.83ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.09ms - 1.09ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.09ms - 1.09msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Dec 22, 2022

Coverage Status

Coverage: 99.43%. Remained the same when pulling 01b9482 on v11-hoist-sort-fn into da7c661 on v11.

@github-actions
Copy link

github-actions bot commented Dec 22, 2022

Size Change: +12 B (0%)

Total Size: 32.6 kB

Filename Size Change
dist/preact.js 4.62 kB +1 B
dist/preact.min.js 4.66 kB +6 B (0%)
dist/preact.umd.js 4.72 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.54 kB 0 B
compat/dist/compat.umd.js 3.62 kB 0 B
debug/dist/debug.js 3.08 kB 0 B
debug/dist/debug.umd.js 3.17 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.umd.js 317 B 0 B
hooks/dist/hooks.js 1.47 kB 0 B
hooks/dist/hooks.umd.js 1.55 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 379 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.umd.js 522 B 0 B

compressed-size-action

@andrewiggins
Copy link
Member

I think #3943 supersedes this since it brings in #3921 from master into v11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants