Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove component.base #4453

Open
wants to merge 1 commit into
base: breaking-changes
Choose a base branch
from
Open

Remove component.base #4453

wants to merge 1 commit into from
+23 −751

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-10.09ms - +11.33ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +3% (-0.29ms - +0.50ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +4% (-1.15ms - +2.74ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -5% - +3% (-0.80ms - +0.46ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.45ms - +2.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +4% (-0.09ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.23ms - +0.35ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +3% (-0.89ms - +0.82ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: faster ✔ 0% - 1% (0.01ms - 0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-0.20ms - +0.22ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.01ms - -0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local874.71ms - 891.84ms-unsure 🔍
-1% - +1%
-10.09ms - +11.33ms
preact-main876.22ms - 889.09msunsure 🔍
-1% - +1%
-11.33ms - +10.09ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.15ms - 25.16ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main25.15ms - 25.15msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.62ms - 17.31ms-unsure 🔍
-2% - +3%
-0.29ms - +0.50ms
preact-main16.66ms - 17.06msunsure 🔍
-3% - +2%
-0.50ms - +0.29ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.69ms-faster ✔
0% - 1%
0.01ms - 0.01ms
preact-main1.70ms - 1.70msslower ❌
0% - 1%
0.01ms - 0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local67.96ms - 71.23ms-unsure 🔍
-2% - +4%
-1.15ms - +2.74ms
preact-main67.75ms - 69.85msunsure 🔍
-4% - +2%
-2.74ms - +1.15ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local13.11ms - 13.43ms-unsure 🔍
-2% - +2%
-0.20ms - +0.22ms
preact-main13.13ms - 13.40msunsure 🔍
-2% - +2%
-0.22ms - +0.20ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.45ms - 17.18ms-unsure 🔍
-5% - +3%
-0.80ms - +0.46ms
preact-main16.48ms - 17.50msunsure 🔍
-3% - +5%
-0.46ms - +0.80ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.61ms - 4.61ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main4.61ms - 4.62msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local80.91ms - 83.40ms-unsure 🔍
-2% - +2%
-1.45ms - +2.01ms
preact-main80.68ms - 83.08msunsure 🔍
-2% - +2%
-2.01ms - +1.45ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.56ms - 3.59ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-main3.57ms - 3.60msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.58ms - 30.10ms-unsure 🔍
-2% - +0%
-0.65ms - +0.08ms
preact-main29.87ms - 30.37msunsure 🔍
-0% - +2%
-0.08ms - +0.65ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.59ms - 37.29ms-unsure 🔍
-6% - +1%
-2.22ms - +0.33ms
preact-main36.44ms - 38.34msunsure 🔍
-1% - +6%
-0.33ms - +2.22ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local27.22ms - 27.77ms-unsure 🔍
-1% - +2%
-0.35ms - +0.47ms
preact-main27.12ms - 27.74msunsure 🔍
-2% - +1%
-0.47ms - +0.35ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local33.13ms - 35.06ms-unsure 🔍
-5% - +2%
-1.91ms - +0.75ms
preact-main33.76ms - 35.60msunsure 🔍
-2% - +6%
-0.75ms - +1.91ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.69ms - 24.44ms-unsure 🔍
-0% - +9%
-0.04ms - +2.09ms
preact-main21.93ms - 23.14msunsure 🔍
-9% - +0%
-2.09ms - +0.04ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local24.72ms - 25.90ms-unsure 🔍
-4% - +3%
-0.96ms - +0.81ms
preact-main24.72ms - 26.04msunsure 🔍
-3% - +4%
-0.81ms - +0.96ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.90ms - 2.02ms-unsure 🔍
-4% - +4%
-0.09ms - +0.08ms
preact-main1.90ms - 2.02msunsure 🔍
-4% - +4%
-0.08ms - +0.09ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main0.98ms - 0.98msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local26.01ms - 26.28ms-unsure 🔍
-1% - +1%
-0.23ms - +0.35ms
preact-main25.83ms - 26.34msunsure 🔍
-1% - +1%
-0.35ms - +0.23ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.65ms - 33.10ms-unsure 🔍
-3% - +3%
-0.89ms - +0.82ms
preact-main31.96ms - 32.87msunsure 🔍
-3% - +3%
-0.82ms - +0.89ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.54ms - 3.54ms-unsure 🔍
-0% - -0%
-0.01ms - -0.01ms
preact-main3.55ms - 3.55msunsure 🔍
+0% - +0%
+0.01ms - +0.01ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

Size Change: -58 B (-0.09%)

Total Size: 61.9 kB

Filename Size Change
compat/dist/compat.js 4.1 kB +5 B (+0.12%)
compat/dist/compat.module.js 4.03 kB +4 B (+0.1%)
compat/dist/compat.umd.js 4.17 kB +3 B (+0.07%)
dist/preact.js 4.71 kB -11 B (-0.23%)
dist/preact.min.js 4.73 kB -11 B (-0.23%)
dist/preact.min.module.js 4.73 kB -11 B (-0.23%)
dist/preact.min.umd.js 4.76 kB -11 B (-0.23%)
dist/preact.module.js 4.72 kB -13 B (-0.27%)
dist/preact.umd.js 4.78 kB -13 B (-0.27%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.7 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.78 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 273 B
devtools/dist/devtools.umd.js 345 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@JoviDeCroock JoviDeCroock mentioned this pull request Jul 23, 2024
Draft
@coveralls
Copy link

coveralls commented Jul 23, 2024 •
edited
Loading

Coverage Status

coverage: 99.486%. remained the same
when pulling 5ac9375 on deprecate-base
into a1c6988 on breaking-changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoviDeCroock @coveralls