Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ownerdocument rebased #4501

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Ownerdocument rebased #4501

wants to merge 20 commits into from

Conversation

alshdavid
Copy link

No description provided.

Hydrophobefireman and others added 18 commits September 16, 2024 14:16
@Hydrophobefireman @alshdavid
Get document from parentNode.ownerDocument instead of relying on glob…
d4f3dcd 
…al (Fixes preactjs#2545)
@Hydrophobefireman @alshdavid
pass the ownerDocument to diffElementNodes
f0c0d67
@Hydrophobefireman @alshdavid
add JSDoc
6546bf1
@Hydrophobefireman @JoviDeCroock @alshdavid
Update src/diff/index.js
4769823 
Co-authored-by: Jovi De Croock <[email protected]>
@Hydrophobefireman @alshdavid
pass ownerDocument to diff function
f86c0e7
@Hydrophobefireman @alshdavid
check if ownerDocument is equal to document
654f111
@Hydrophobefireman @alshdavid
check spy.get
4d8a40e
@Hydrophobefireman @alshdavid
prevent multiple gets of ownerDocument
0e96d7a
@Hydrophobefireman @alshdavid
fix ownerDocument being null when passed down to diff()
01efec9
@Hydrophobefireman @alshdavid
remove unused variable
db8ec2b
@Hydrophobefireman @alshdavid
prevent repeated access of parentNode.ownerDocument
3f586c0
@Hydrophobefireman @alshdavid
run tests for an iframe
d22c124
@Hydrophobefireman @alshdavid
remove unused import
53a2551
@Hydrophobefireman @alshdavid
Delete index.js.rej
236e506
@Hydrophobefireman @alshdavid
check ownerDocument of the rendered textNode
919862b
@Hydrophobefireman @alshdavid
add spy on createTextNode
bddd350
@andrewiggins @alshdavid
Fix portals
38060aa
@andrewiggins @alshdavid
Improve test
cadcc54
@alshdavid alshdavid mentioned this pull request Sep 16, 2024
Open
@JoviDeCroock
Copy link
Member

Looks like the tests are currently failing when passing in document as a render-target. This is a valid use-case to render a full HTML tree and that indeed has null for the ownerDocument so we'd have to take a null'ish ownerDocument into account and default to document I reckon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alshdavid @JoviDeCroock @Hydrophobefireman @andrewiggins