[CARE-6003][CARE-5923] Clean up Algolia code #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pestaa
commented
Aug 30, 2024
pestaa
commented
- [CARE-6003] Clean up Algolia code from themes
- [CARE-5923] Fix facet filter weirdness on Bea
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
kudlajz
approved these changes
Sep 10, 2024
| index: string; | ||
| }; | ||
| export type SearchSettings = { | ||
| searchBackend: 'meilisearch'; |
There was a problem hiding this comment.
I think this property is no longer needed since there's only one backend.
There was a problem hiding this comment.
For now, yes, but we haven't removed multi-engine support from backend either, that will be the foundation for upgrading between major versions.
…an-up-algolia-code-from-themes
pestaa
deleted the
feature/care-6003-clean-up-algolia-code-from-themes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.