Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safe_int_mm for H100 #882

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jainapurva
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Sep 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/882

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c7e5fdf with merge base 85d03de (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
Copy link
Contributor

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure the model runs on the specified device given these changes? it looksl ike they don't. I think you need to go back and if this is an issue with .to(device) after compile, can you change it so it does compile right at the end and does .to(device) right beforehand?

@jerryzh168
Copy link
Contributor

can you make sure the model runs on the specified device given these changes? it looksl ike they don't. I think you need to go back and if this is an issue with .to(device) after compile, can you change it so it does compile right at the end and does .to(device) right beforehand?

@HDCharles should we refactor the quantization code in eval/benchmark/hf_eval to a util? lots of duplications right now I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants