Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optim-wip: Improve & fix LaplacianImage #967

Open
wants to merge 30 commits into
base: optim-wip
Choose a base branch
from

Conversation

ProGamerGov
Copy link
Contributor

@ProGamerGov ProGamerGov commented Jun 4, 2022

  • Improved the LaplacianImage code as part of removing the ToDo comment.
  • Added "same" padding option to GaussianSmoothing.
  • Improved the NaturalImage docs.
    • Also removed the built-in clamp squash function. It's inclusion was an aesthetic choice, and it's easy enough for users to add on their own.
  • Added the new indexing argument for torch.meshgrid in GaussianSmoothing as it will be required in future PyTorch versions.
  • Changed depreciated self.assertEquals to self.assertEqual.
  • Use register_full_backward_hook instead of register_backward_hook for applicable tests, as the later is being depreciated.
  • Added dtype tests to for image parameterizations & transforms.

* Improved `LaplacianImage` code as part of removing the ToDo comment.
* Added `"same"` padding option to `GaussianSmoothing`.
* Improved the `NaturalImage` docs.
* Also removed built-in clamp squash function. It's inclusion was an aesthetic choice, and it's easy enough for users to add on their own.
* Update images.py

* Update images.py
…ouble

It seems to occur in ToRGB on 3 different tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants