Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pr to support dynamic shape detection #7817

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Aug 7, 2024

The implementation in this pr is not ideal because it can only handle a single graph for a compiled program. This is usually too strict for the real world program because in training we usually at least have 2 graphs since in the step0 the optimizer state is not initialized.

I think what I need to do next is to provide a max_dynamic_graph_allowed arguments and use a TRIE to keep tracked of all the IR being generated and when they diverage.

@JackCaoG
Copy link
Collaborator Author

rioght now if I used this feature in https://github.com/pytorch/xla/blob/master/examples/train_decoder_only_base.py it will error out because second step graph is different from the first step one(most likely due to the optimizer state).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant