[benchmarks] Add docs file. #8023
Draft
+474
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miladm
reviewed
Sep 16, 2024
|
|
||
| **PyTorch/XLA Metrics:** (repeat-specific) the flag `--dump-pytorch-xla-metrics` creates a | ||
| new file, dumping PyTorch/XLA metrics, such as graph compiling and execution information. | ||
|
|
There was a problem hiding this comment.
Can we have a section on Nightly CI runs - TPU and GPU
There was a problem hiding this comment.
Sure. But I don't really have any information on those nightly CI runs. What should it contain?
miladm
reviewed
Sep 16, 2024
|
|
||
| **PyTorch/XLA Metrics:** (repeat-specific) the flag `--dump-pytorch-xla-metrics` creates a | ||
| new file, dumping PyTorch/XLA metrics, such as graph compiling and execution information. | ||
|
|
There was a problem hiding this comment.
Can we include a troubleshooting section? this should include the pitfalls we ran into as well as approaches to debug the benchmark efficiently.
There was a problem hiding this comment.
@miladm I don't think it is appropriate to document any resolved issue here. If there are any features that can be used to debug different performance issues we should absolutely make sure they are captured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.