parallel_loader: Fix TPU memory leak when calling __iter__. #8039
+43
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-cromar
approved these changes
Sep 19, 2024
|
LGTM. Please address the linter complaints, then we can merge this |
A TPU memory leak occurs when calling __iter__ on the MpDeviceLoader object, even if called only once. However, the memory growth becomes more noticeable and critical when __iter__ is called repeatedly, eventually leading to a crash. This issue is caused by the threads not being properly terminated because the close() method was not invoked. This commit resolves the issue by ensuring that close() is called, which properly shuts down the threads and prevents memory from leaking.
dudulightricks
force-pushed
the
bug-fix/mp-device-loader-memory-leak
branch
from
984af38
to
744bf9b
Compare
|
@will-cromar Thanks. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TPU memory leak occurs when calling iter on the MpDeviceLoader object, even if called only once. However, the memory growth becomes more noticeable and critical when iter is called repeatedly, eventually leading to a crash. This issue is caused by the threads not being properly terminated because the close() method was not invoked.
This commit resolves the issue by ensuring that close() is called, which properly shuts down the threads and prevents memory from leaking.