Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add new acceptance test project #359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hkupty
Copy link

@hkupty hkupty commented Oct 9, 2023

Reference: #357

So, I've decided to start simple and go with a basic set of tests, with the intention of iteratively going through some cases and getting to a point where this is actually usable by other slf4j implementations.

I also took the chance to implement it for slf4j-simple as means of testing the API.

I went on with your suggestion as it seems to be more fitting to the usual java projects and, although AcceptanceTest doesn't look like a regular test file I'm quite satisfied with how it looks, so I'm curious for your opinion.

I'm keeping this PR as draft for now as I'm of course willing to add more tests and adapt names, project structure and other small details.

Looking forward to hearing your opinion.

@hkupty hkupty marked this pull request as ready for review October 18, 2023 15:01
@hkupty
Copy link
Author

hkupty commented Oct 18, 2023

I'm relatively happy with this approach. I'd like to know whether we need more cases for org.slf4j.Logger implementations.

Additional suites should be created after this one for Marker and MDC support I'd say. I'm not sure if those should come in the same PR or in a separate batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant