Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data-table): add DataTableReactive example #744

Merged
merged 7 commits into from
Aug 31, 2024

Conversation

hrynevychroman
Copy link
Collaborator

πŸ”— Linked issue

This PR fix #700

❓ Type of change

Added new Example with randomize button to show how exactly we need to mutate reactive data.

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

shadcn-tanstack-table.mp4

πŸ“Έ Screenshots (if appropriate)

Also rephrase docs, seems good to me:
image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@hrynevychroman hrynevychroman self-assigned this Aug 31, 2024
@hrynevychroman hrynevychroman changed the title docs(table): add DataTableReactive example and Tanstack docs docs(table): add DataTableReactive example Aug 31, 2024
@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Aug 31, 2024

Could you please merge upstream dev or your origin dev branch here? and then run the build registry again

Thanks ❀️

@hrynevychroman
Copy link
Collaborator Author

Could you please merge upstream dev or your origin dev branch here? and then run the build registry again

Done in 92801dc (#744)

@hrynevychroman hrynevychroman changed the title docs(table): add DataTableReactive example docs(data-table): add DataTableReactive example Aug 31, 2024
Copy link
Collaborator

@sadeghbarati sadeghbarati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️

@sadeghbarati sadeghbarati merged commit 481bebf into radix-vue:dev Aug 31, 2024
1 check passed
@hrynevychroman hrynevychroman deleted the fix/tanstack-table branch August 31, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version of TanStack table library
2 participants