Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy: finalize FR updates for most translated pages #658

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

tdd
Copy link
Collaborator

@tdd tdd commented Jul 24, 2024

This covers all pages that were already translated and needed updates for all sync-PR-initiated content updates.

Recent new pages are not translated yet.

@tdd tdd added Reviewed scope:required-pages Part of the required translations before we can ship translator:seasoned The author of that translation is a seasoned React docs translator labels Jul 24, 2024
@tdd tdd self-assigned this Jul 24, 2024
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 105.38 KB (🟡 +96 B) 209.16 KB
/500 105.37 KB (🟡 +96 B) 209.15 KB
/[[...markdownPath]] 107.35 KB (🟡 +96 B) 211.13 KB
/errors 105.61 KB (🟡 +96 B) 209.39 KB
/errors/[errorCode] 105.59 KB (🟡 +96 B) 209.37 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@tdd tdd merged commit 53c0122 into main Jul 24, 2024
4 checks passed
@tdd tdd deleted the l10n-fr-updates branch July 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed scope:required-pages Part of the required translations before we can ship translator:seasoned The author of that translation is a seasoned React docs translator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant