Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#61 - Migrate to Graphology #108

Merged
merged 12 commits into from
Jul 6, 2023
Merged

#61 - Migrate to Graphology #108

merged 12 commits into from
Jul 6, 2023

Conversation

amcdnl
Copy link
Member

@amcdnl amcdnl commented Jul 5, 2023

This PR:

  • Migrates from ngraph to graphology
  • Fixes node drag bug
  • Adds no overlap layout
  • Adds forceatlas2 layout
  • Removed lodash
  • Doc Cleanup

@amcdnl amcdnl self-assigned this Jul 5, 2023
@amcdnl amcdnl marked this pull request as ready for review July 6, 2023 18:51
@amcdnl amcdnl changed the title Migrate to Graphology #61 - Migrate to Graphology Jul 6, 2023
@amcdnl amcdnl merged commit 36c83dc into master Jul 6, 2023
1 check passed
@amcdnl amcdnl deleted the graphology branch July 6, 2023 18:54
@Marrocco-Simone
Copy link

I get this error with the new version in nextjs 13:

- error Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/path_to_project/node_modules/graphology-layout/circular' imported from /path_to_project/node_modules/reagraph/dist/index.js
Did you mean to import graphology-layout/circular.js?
    at new NodeError (node:internal/errors:400:5)
    at finalizeResolution (node:internal/modules/esm/resolve:260:11)
    at moduleResolve (node:internal/modules/esm/resolve:879:10)
    at defaultResolve (node:internal/modules/esm/resolve:1087:11)
    at nextResolve (node:internal/modules/esm/loader:161:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:834:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:415:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:77:40)
    at link (node:internal/modules/esm/module_job:76:36) {
  digest: undefined
}

@amcdnl
Copy link
Member Author

amcdnl commented Jul 7, 2023

Did the previous version work w/ next?

@Marrocco-Simone
Copy link

Marrocco-Simone commented Jul 7, 2023

Yes, it works. The error came with the simple code on the npm page

@amcdnl
Copy link
Member Author

amcdnl commented Jul 7, 2023

Thank you - was just trying to isolate the issue.

@amcdnl amcdnl added bug Something isn't working and removed bug Something isn't working labels Jul 7, 2023
@benjick
Copy link

benjick commented Sep 1, 2023

Any workaround?

@amcdnl
Copy link
Member Author

amcdnl commented Sep 1, 2023

Any workaround?

It should be fixed - let me know if not

@benjick
Copy link

benjick commented Sep 1, 2023

@amcdnl I just generated a new NextJS project using t3 (https://t3.gg/) and installed the package: "reagraph": "^4.13.0",

Then I just followed the basics example, from here: https://reagraph.dev/?path=/docs/docs-getting-started-basics--docs

Giving me the following error:

Error: Cannot find module '/Users/max/dev/docker-vis/node_modules/graphology-layout/circular' imported from /Users/max/dev/docker-vis/node_modules/reagraph/dist/index.js
Did you mean to import graphology-layout/circular.js?

@amcdnl
Copy link
Member Author

amcdnl commented Sep 1, 2023

Ugh - OK - I thought this was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants