Fix fit view bug after panning and zooming #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If you pan and zoom, then fit nodes to the view, sometimes the view doesn't fit properly
What is the new behavior?
The view always fits properly
Does this PR introduce a breaking change?
Other information
This awaits the zoom reset before positioning the camera when triggering
fitNodesInView
. Now there's a visual split between zooming and positioning the camera, but it's better than the view not being fit to the nodes properlyBEFORE
(happened on the 3rd fit to view trigger)
Screen.Recording.2024-05-23.at.12.37.49.PM.mov
AFTER
Screen.Recording.2024-05-23.at.12.39.36.PM.mov
Note: If you only zoom or only pan, there's no wonky/jumpyness when fitting the view