Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dolly camera controls #247

Merged
merged 2 commits into from
May 30, 2024
Merged

Add dolly camera controls #247

merged 2 commits into from
May 30, 2024

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented May 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There's no way to dolly the camera other than mouse scroll wheel

What is the new behavior?

There's camera control methods to dolly in and out

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The mouse scroll wheel dolly's the camera towards the mouse position. Doing this in combination with zoom can leave the graph in a weird state because dolly has min and max values while zoom does not (e.g. zoom very far in, then you can only dolly back out with the scroll wheel a limited amount. It's not clear these are 2 different methods)

This adds dolly methods to the camera controls that are more comfortable to use in combination with the mouse scroll wheel

Screen.Recording.2024-05-29.at.2.53.31.PM.mov

@ghsteff ghsteff requested a review from amcdnl May 29, 2024 19:55
Copy link

netlify bot commented May 29, 2024

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit a04e703
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/665788370cce8c00082e4669
😎 Deploy Preview https://deploy-preview-247--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit de3ae0a into master May 30, 2024
5 checks passed
@amcdnl amcdnl deleted the Add-dolly-camera-controls branch May 30, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants