replace react-use-gesture to @use-gesture/react #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ghsteff
approved these changes
Jul 25, 2024
ghsteff
requested changes
Jul 25, 2024
|
Here's a video of the Screen.Recording.2024-07-25.at.11.56.47.AM.mov |
ghsteff
reviewed
Jul 25, 2024
src/utils/useDrag.ts
Outdated
Comment on lines
64
to
78
| onDrag: ({ event }) => { | ||
| // Compute normalized mouse coordinates (screen space) | ||
| const nx = | ||
| ((event.clientX - (clientRect?.left ?? 0)) / size.width) * 2 - 1; | ||
| const ny = | ||
| -((event.clientY - (clientRect?.top ?? 0)) / size.height) * 2 + 1; | ||
| let clientX, clientY; | ||
| if (event instanceof MouseEvent || event instanceof PointerEvent) { | ||
| clientX = event.clientX; | ||
| clientY = event.clientY; | ||
| } else if (event instanceof TouchEvent) { | ||
| clientX = event.touches[0].clientX; | ||
| clientY = event.touches[0].clientY; | ||
| } else { | ||
| return; | ||
| } | ||
|
|
||
| const nx = ((clientX - (clientRect?.left ?? 0)) / size.width) * 2 - 1; | ||
| const ny = -((clientY - (clientRect?.top ?? 0)) / size.height) * 2 + 1; |
There was a problem hiding this comment.
Hmmm playing around with this and the types for event seem wrong. It's hitting the else { return } block every time
This should work with no ts complaints tho
onDrag: ({ xy }) => {
// Compute normalized mouse coordinates (screen space)
const nx = ((xy[0] - (clientRect?.left ?? 0)) / size.width) * 2 - 1;
const ny = -((xy[1] - (clientRect?.top ?? 0)) / size.height) * 2 + 1;
There was a problem hiding this comment.
Will do tomorrow, thanks!🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
react-use-gesture is not maintained and @use-gesture/react is the successor
Issue Number: N/A
What is the new behavior?
Warning of react-use-gesture during
npm iDoes this PR introduce a breaking change?
Other information