Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #11886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some comments #11886

wants to merge 1 commit into from

Conversation

pwdcd
Copy link

@pwdcd pwdcd commented Aug 14, 2024

No description provided.

Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 299cd6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 14, 2024

Hi @pwdcd,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@brophdawg11
Copy link
Contributor

Thank you! Would you mind signing the CLA so we can get this merged?

@pwdcd
Copy link
Author

pwdcd commented Aug 15, 2024

Thank you! Would you mind signing the CLA so we can get this merged?

Of course. Signed.

Please review again

@timdorr
Copy link
Member

timdorr commented Aug 15, 2024

You need to add your username to the contributors.yml file. That is how we track signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants