Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install zstd in an alternate directory (#1172) #1179

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

jpsamper2009
Copy link

This prevents the compiled libzstd from being used by the host's cmake executable

Fixes #1172

This prevents the compiled libzstd from being used by
the host's cmake executable

Signed-off-by: Juan Pablo Samper <[email protected]>
@jpsamper2009 jpsamper2009 requested a review from a team as a code owner November 23, 2022 22:20
@jpsamper2009 jpsamper2009 requested review from hidmic and james-rms and removed request for a team November 23, 2022 22:20
@MichaelOrlov
Copy link
Contributor

Hi JP @jpsamper2009 Thanks for the PR.
There are a compilation errors in rosbag2_compression_zstd package

-- stderr: rosbag2_compression_zstd
14:22:09 CMake Error at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
14:22:09   Could NOT find zstd (missing: zstd_LIBRARY zstd_INCLUDE_DIR)
14:22:09 Call Stack (most recent call first):
14:22:09   /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
14:22:09   /tmp/ws/install_isolated/zstd_vendor/share/zstd_vendor/cmake/Modules/Findzstd.cmake:36 (find_package_handle_standard_args)
14:22:09   CMakeLists.txt:28 (find_package)
14:22:09 
14:22:09 
14:22:09 ---
14:22:09 Failed   <<< rosbag2_compression_zstd [1.48s, exited with code 1]

It looks like need to adjust path in zstd_vendor/cmake/Modules/Findzstd.cmake as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zstd_vendor breaks CMake when cross-compiling for QNX
2 participants