Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the pointer event overhaul #3876

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Implement the pointer event overhaul #3876

wants to merge 7 commits into from

Commits on Aug 23, 2024

  1. Implement the pointer event overhaul 

    - Rename `CursorMoved` to `PointerMoved`.
- Rename `CursorEntered` to `PointerEntered`.
- Rename `CursorLeft` to `PointerLeft`.
- Rename `MouseInput` to `PointerButton`.
- Add `position` to every `PointerEvent`.
- Remove `Touch`, which is folded into the `Pointer*` events.
- New `PointerType` added to `PointerEntered` and `PointerLeft`, signifying which pointer type is
  the source of this event.
- New `PointerSource` added to `PointerMoved`, similar to `PointerType` but holding additional
  data.
- New `ButtonSource` added to `PointerButton`, similar to `PointerType` but holding pointer type
  specific buttons. Use `ButtonSource::mouse_button()` to easily normalize any pointer button
  type to a generic mouse button.
- In the same spirit rename `DeviceEvent::MouseMotion` to `PointerMotion`.
- Remove `Force::Calibrated::altitude_angle`.
    @daxpedda
    daxpedda committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c899a10 View commit details
    Browse the repository at this point in the history

  2. Address review

    @daxpedda
    daxpedda committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8e9b1bc View commit details
    Browse the repository at this point in the history

  3. Rename PointerType to PointerKind

    @daxpedda
    daxpedda committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    116c265 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary checks in MacOS

    @daxpedda
    daxpedda committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b6d956c View commit details
    Browse the repository at this point in the history

  5. Document ButtonSource::mouse_button()

    @daxpedda
    daxpedda committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2a62376 View commit details
    Browse the repository at this point in the history

  6. Remove TouchPhase from Android touch handling

    @daxpedda
    daxpedda committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b07d223 View commit details
    Browse the repository at this point in the history

  7. Handle tool type on Android

    @daxpedda
    daxpedda committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9ecf564 View commit details
    Browse the repository at this point in the history