Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground] Click to Copy #1177

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[Playground] Click to Copy #1177

wants to merge 19 commits into from

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Sep 10, 2024

Adds Click to Copy to input and output panes in the playground.

Addresses item 2 in #779.

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for sass-lang ready!

Name Link
🔨 Latest commit 93a4f1a
🔍 Latest deploy log https://app.netlify.com/sites/sass-lang/deploys/66e9eeb33c3c5e00089aab5a
😎 Deploy Preview https://deploy-preview-1177--sass-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like making the existing copy button match the new visual copy indicators 😃

source/assets/js/playground.ts Outdated Show resolved Hide resolved
source/assets/js/playground.ts Outdated Show resolved Hide resolved
Comment on lines 36 to 37
$sl-color--text-medium-dark: #5e6470; // darker version of pale-sky
$sl-color--action-dark: #a12d69; // darker version of action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be defined in terms of color.scale() or color.adjust()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nex3 I can update that. I just quickly used a color app's down arrows until it passed. I can switch to a more readable format and look up the exact adjustments to use to make it work based on the brand colors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate it! We may also move to new color spaces for color conversions at some point, at which point knowing the underlying logic is valuable because we can just make the results more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants