Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a static build #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix a static build #224

wants to merge 2 commits into from

Conversation

ahorek
Copy link

@ahorek ahorek commented Jun 15, 2021

on Windows, LIBWINPTHREAD-1.DLL is still linked dynamically

a static build shouldn't depend on external libraries. Especially JRuby should be able to load the static library at runtime without a devkit environment. However, devkit tools are still necessary to build the library on JRuby. see #182 (comment)

@mohits
Copy link

mohits commented Jun 16, 2021

Thanks for fixing this! I guess this will be deployed in the next gem release? For now, I can see that if I add c:\Ruby26-x64\msys64\mingw64\bin it is able to find LIBWINPTHREAD-1.DLL and related dependencies to be able to load sassc from JRuby. I have this note added to my post about building and installing sassc within JRuby, and will update it once it works without this workaround :)

@enebo
Copy link

enebo commented Nov 19, 2021

Any chance we can get this in a release? Having to have a C tool chain on windows for JRuby to install one gem is pretty inconvenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants