Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor code quality issues #263

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

powerexploit
Copy link

Description

Hey 👋 , I'm member of the Developer Outreach team at DeepSource and ran DeepSource analysis on my fork of the repo. It found some interesting code quality improvements to consider.

This PR fixes a few of the issues detected for you to assess if it is right for you.
Happy to provide the tweaks separately otherwise :)

Important changes

  • Removed unused import
  • Refactor 'if' expression
  • Added .deepsource.toml file for continuous analysis on bug risks/performance/code-quality issues on new changes.

…ormance/code-quality issues

Signed-off-by: ankitdobhal <[email protected]>
Signed-off-by: ankitdobhal <[email protected]>
Signed-off-by: ankitdobhal <[email protected]>
@powerexploit powerexploit marked this pull request as ready for review March 20, 2021 09:53
@@ -78,7 +78,7 @@
while True:
title = content.next()
cat = content.next().strip()
is_new = True if cat[-1]=="*" else False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errado, arruma o true if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants