Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Fixes #15185 - adds accessories to locations and asset screens #15235

Draft
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 7, 2024

WIP. The previous PR did not allow admins to see the accessories checked out to locations or assets on the ___location or asset pages themselves, which would make for a very confusing user experience. Unfortunately, this PR is big since there was a lot still left to do :(

Still working on it, but I don't know if I'll be able to finish it before I leave for vacation.

Since the locations tabs can get very crowded, I'm also experimenting with icons instead of text:

Screenshot 2024-08-07 at 5 17 34 PM

Things remaining

  • clean up the morph relationships - I think we can make these a little cleaner
  • pull out the AccessoryCheckout controller - I don't think we actually need it
  • add the tab for accessories checked out to assets
  • fix the tab for accessories checked out to locations: either pull the "checked out to" (since it's obvious anyway) or figure out why the assignedTo coms up blank on that endpoint
  • account for the new accessories in the print assigned options for locations
  • revert Partial revert for checkout accessories to non user #15241 once this is all working properly

Copy link

what-the-diff bot commented Aug 7, 2024

PR Summary

  • Improvement in Accessories Tracking
    We improved the way we handle data related to accessories. A new method called 'transformCheckedoutAccessory' has been incorporated and its implementation has been updated across various controllers including Accessories, Locations, and Assets Controllers.

  • Assigned Accessories Tracking at Locations
    Locations Controller got an update with a new method 'assignedAccessories'. This will enhance our tracking of the accessories allocated to various locations.

  • New Compact Location Information
    We introduced a new method called 'transformLocationCompact' to LocationsTransformer, allowing efficient representation of ___location-related data within the LocationsController.

  • Improved User Information Handling
    UsersTransformer saw an update with the introduction of 'transformUserCompact', a method that enables efficient handling of user-specific information within the AccessoriesTransformer.

  • Extended Accessory Details
    The method 'transformCheckedoutAccessory' in AccessoriesTransformer has been revised to include extra fields, giving us better detail about each accessory.

  • Better Filtering in AccessoryCheckout
    The AccessoryCheckout model has been updated to filter by assigned type, enhancing our visibility of which types of accessories are allocated.

  • Enhanced Interface for Accessories
    AccessoryPresenter now includes a new layout for showing assigned accessories, introducing a better user experience.

  • UI Updates for Accessories and Locations
    The user interface for 'accessories' and 'locations' now includes a new tab dedicated to assigned accessories, providing users with a more holistic view of accessory allocation.

  • Enhanced API for Accessories Retrieval
    A new API route has been incorporated to fetch the assigned accessories for a ___location, allowing for more targeted data retrieval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant