-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Purchase Cost to Asset Model #15273
base: develop
Are you sure you want to change the base?
Conversation
PR Summary
|
I'm not sure we want to do an explicit thing here. I think (similar to the way eol date used to work) we just offer that as a prepopulated value when the asset gets created. |
Question: if there was purchase of a model with upgrades making it a different cost then the model, do we want to put an indicatior for some reason on the asset info page noting that? |
Perhaps just noting the model's default price would be enough? That could get confusing if the model's cost went up over time though - could make it look like it's a cheaper machine, when really it's just an older machine. |
The challenge I see here is that if someone wants to deliberately leave a purchase cost blank on an asset, there isn't really a way to do it using this method. |
Ping @Godmartinz |
Should we maybe add a button next to the input |
Description
This adds a
purchase_cost
to the models table. If an asset assigned the model leaves a blank purchase cost when creating a new asset, it will inherit the purchase cost from the model This only applies to when creating assets, and will not happen when updating or leaving the purchase cost blank in an editA help info line has been added to the create route.
On the create route:
On the Update/edit route:
Fixes #15237
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: