Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed double webhook notifications // Separated email and webhook notifications. #15524

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Sep 18, 2024

Description

Seperated the notification call in the checkoutable listener to exclude $notifiables from webhook notifications. With the way things were, if you had more than one email to notify it would send an additional webhook notification.
image

This removes that bug.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested review from marcusmoore and removed request for snipe September 18, 2024 23:22
Copy link

what-the-diff bot commented Sep 18, 2024

PR Summary

  • Improvement in Email Notification System
    The system of sending out email notifications has been improved. Now, each user who should receive a notification will do so according to their email and locale preferences.

  • Conditionally Send Notifications for Checkout and Checkin Events
    We've added a feature that decides whether to send notifications for checkout and checkin events depending on the specific user instances.

  • Enhancement in Webhook Notification Functionality
    Notification features that use webhooks have been honed. They will now inform different channels depending on the chosen webhook setting, ensuring both checkout and checkin events are rightly notified.

  • Cleaning up and Streamlining Notification Handling
    Obsolete comments have been removed and the handling of both email and webhook notifications has been streamlined for more efficiency.

@snipe snipe changed the title Fixed double webhook notifications // Seperated email and webhook notifications. Fixed double webhook notifications // Separated email and webhook notifications. Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant