feat: strokeDasharray with Animated #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
changed the title
|
@pavel-stryber could you check if applying this PR fixes your problems with |
|
I have added small changes to example. Changed animation implementation from plain react native to 'react-native-reanimated'. Also, changed testing component. I guess, you accidentally set Tested on iOS and Android, all works fine now. Here my PR for reference: #2090 |
|
Ok thanks, I updated the example. Also, I want to keep the |
1 task
|
Big thanks @WoLewicki, I didn't expect how fast it was. |
renovate bot
added a commit
to valora-inc/wallet
that referenced
this pull request
Oct 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^13.9.0` -> `^13.14.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.9.0/13.14.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v13.14.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.14.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.13.0...v13.14.0) PR adding improvements to the library. Thanks for all your contributions 🚀 #### What's Changed - Create FUNDING.yml by [@​aleqsio](https://togithub.com/aleqsio) in [software-mansion/react-native-svg#2133 - docs: Update deprecated expo install instructions to \`npx expo install´ by [@​GabrieldosSantosOliveira](https://togithub.com/GabrieldosSantosOliveira) in [software-mansion/react-native-svg#2128 - \[macOS]\[Xcode 15] Avoid using dirtyRect in `drawRect:` by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [software-mansion/react-native-svg#2136 - fix: error for transform on web by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2139 - chore(deps): bump activesupport from 6.1.7.4 to 7.0.7.2 in /TestsExample by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2122 - fix: web not working with reanimated in example by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2140 #### New Contributors - [@​aleqsio](https://togithub.com/aleqsio) made their first contribution in [software-mansion/react-native-svg#2133 - [@​GabrieldosSantosOliveira](https://togithub.com/GabrieldosSantosOliveira) made their first contribution in [software-mansion/react-native-svg#2128 - [@​Saadnajmi](https://togithub.com/Saadnajmi) made their first contribution in [software-mansion/react-native-svg#2136 **Full Changelog**: software-mansion/react-native-svg@v13.13.0...v13.14.0 ### [`v13.13.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.13.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.12.0...v13.13.0) Minor release restoring usage of `UIGraphicsBeginImageContextWithOptions` on `macOS` since there is no implementation for `UIGraphicsImageRendererFormat` there yet. #### What's Changed - feat: add macos back to Example app by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2119 **Full Changelog**: software-mansion/react-native-svg@v13.12.0...v13.13.0 ### [`v13.12.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.12.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.11.0...v13.12.0) Minor release introducing the change of API used on `iOS` from [UIGraphicsBeginImageContextWithOptions](https://developer.apple.com/documentation/uikit/1623912-uigraphicsbeginimagecontextwitho) to [UIGraphicsImageRenderer](https://developer.apple.com/documentation/uikit/uigraphicsimagerenderer). #### What's Changed - feat: remove UIGraphicsBeginImageContextWithOptions from repo by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2117 **Full Changelog**: software-mansion/react-native-svg@v13.11.0...v13.12.0 ### [`v13.11.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.11.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.10.0...v13.11.0) Minor release cleaning the repository 🧹 Please submit any issues that come up with the newest version 🐛 Thanks for your contributions 🚀 #### What's Changed - fix: make web platform types compatible with native types by [@​nderscore](https://togithub.com/nderscore) in [software-mansion/react-native-svg#2091 - docs: update usage.md for react-native 0.72 by [@​Letty](https://togithub.com/Letty) in [software-mansion/react-native-svg#2104 - docs: update README.md by [@​Mhp23](https://togithub.com/Mhp23) in [software-mansion/react-native-svg#2110 - fix: bump packages, eslint, tsconfig, prettier and resolve all conflicts by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2114 #### New Contributors - [@​nderscore](https://togithub.com/nderscore) made their first contribution in [software-mansion/react-native-svg#2091 - [@​Letty](https://togithub.com/Letty) made their first contribution in [software-mansion/react-native-svg#2104 - [@​Mhp23](https://togithub.com/Mhp23) made their first contribution in [software-mansion/react-native-svg#2110 **Full Changelog**: software-mansion/react-native-svg@v13.10.0...v13.11.0 ### [`v13.10.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.10.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.9.0...v13.10.0) Minor release fixing some long-standing issues, adding new features such as web support for `toDataURL` ([software-mansion/react-native-svg#2072) and `fallback` prop for `SvgXml` and others ([software-mansion/react-native-svg#2071). It also adds support for RN 0.72 on **new architecture**, at the same time dropping the support for RN 0.71 there. Thanks for all your contributions 🚀 #### What's Changed - Fix compilation errors on Windows by [@​christophpurrer](https://togithub.com/christophpurrer) in [software-mansion/react-native-svg#2045 - Fix setNativeProps type by [@​fauri13](https://togithub.com/fauri13) in [software-mansion/react-native-svg#2058 - fix: remove deprecated import from react-native-web by [@​janlat](https://togithub.com/janlat) in [software-mansion/react-native-svg#2027 - fix: Updating iOS version [#​2038](https://togithub.com/react-native-community/react-native-svg/issues/2038) by [@​sgabriel](https://togithub.com/sgabriel) in [software-mansion/react-native-svg#2041 - Fix syntax error in RNSVGImageShadowNode::initialStateData by [@​hsjoberg](https://togithub.com/hsjoberg) in [software-mansion/react-native-svg#2079 - Fix [#​1345](https://togithub.com/react-native-community/react-native-svg/issues/1345): opacity does not work with currentColor on Android by [@​laptou](https://togithub.com/laptou) in [software-mansion/react-native-svg#2080 - chore: bump Example to 0.72 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2084 - chore(deps): bump fast-xml-parser from 4.1.3 to 4.2.4 in /TestsExample by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2063 - chore(deps): bump vm2 from 3.9.14 to 3.9.19 by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2056 - chore(deps): bump fast-xml-parser from 4.2.4 to 4.2.5 in /TestsExample by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2085 - Add web support for toDataURL() on svg tags by [@​chrispader](https://togithub.com/chrispader) in [software-mansion/react-native-svg#2072 - Prevents SvgUri crashes when uri is invalid and adds fallback prop by [@​PiotrWszolek](https://togithub.com/PiotrWszolek) in [software-mansion/react-native-svg#2071 - chore: run prettier and lint by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2087 - chore: bump TestsExample to 0.72 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2088 - feat: strokeDasharray with Animated by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2089 #### New Contributors - [@​christophpurrer](https://togithub.com/christophpurrer) made their first contribution in [software-mansion/react-native-svg#2045 - [@​fauri13](https://togithub.com/fauri13) made their first contribution in [software-mansion/react-native-svg#2058 - [@​janlat](https://togithub.com/janlat) made their first contribution in [software-mansion/react-native-svg#2027 - [@​sgabriel](https://togithub.com/sgabriel) made their first contribution in [software-mansion/react-native-svg#2041 - [@​laptou](https://togithub.com/laptou) made their first contribution in [software-mansion/react-native-svg#2080 - [@​chrispader](https://togithub.com/chrispader) made their first contribution in [software-mansion/react-native-svg#2072 - [@​PiotrWszolek](https://togithub.com/PiotrWszolek) made their first contribution in [software-mansion/react-native-svg#2071 **Full Changelog**: software-mansion/react-native-svg@v13.9.0...v13.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR adding the proper handling of
strokeDasharrayprop for when used withAnimated. Code based on #1464 by @bardliu, but with the newest state of the repository.Test Plan
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md__tests__folder