Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Scala 3 #44

wants to merge 3 commits into from

Conversation

keynmol
Copy link

@keynmol keynmol commented Mar 13, 2022

There are some non-trivial changes that I had to make, so let's have a discussion here.

  1. Add Scala 3 to cross build
  2. Exclude Scala 3 Native combination from tests (see scala-native Scala 3 support scalatest/scalatest#2097)
  3. Adjust flags for the Scala.js on Scala 3 combination
  4. Update SBT to 1.6.x
  5. Update Scala.js to 1.9.0 (can be dropped down to 1.7.0, but not lower as that's the IR version that Dotty starts out with)
  6. Change do...while to recommended construct in https://docs.scala-lang.org/scala3/reference/dropped-features/do-while.html
  7. Remove auto-application issue on Scala 3 (see https://docs.scala-lang.org/scala3/reference/dropped-features/auto-apply.html#inner-main) - this is not binary compatible, as I removed case from Arg and Fragment classes

@@ -1,6 +1,6 @@
package trail

case class Arg[T]()(implicit val codec: Codec[T]) {
class Arg[T]()(implicit val codec: Codec[T]) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues like

[error] 134 |        val bar = !# / "asdf" / Arg[Int] / Arg[Boolean]
[error]     |                                           ^^^^^^^^^^^^
[error]     |            method apply in object Arg must be called with () argument

@lolgab
Copy link
Contributor

lolgab commented Apr 28, 2022

@keynmol scalatest 3.2.12 was released with native0.4_3 artifacts :-)

@keynmol
Copy link
Author

keynmol commented May 21, 2022

@tindzk seems like Travis pipelines are not running - if you want I can add a GH workflow for tests, you'll just need to enable GH actions for this repository.

@DeamonDev
Copy link

So what about that PR? I would like to use this library together with Tyrian and for that case I definitely need Scala 3 version of trail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants