Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhooks): forcefully convert response.body() to String #4137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morbid98
Copy link

This should fix spinnaker/spinnaker#6454.
Apparently, response.body(), which is returned from webhook is not a string, which breaks JsonPath parsing to bind an artifact. Forcing response.body() to be a string fixes that issue.

@mattgogerly
Copy link
Member

Any chance of a test case for this? @morbid98

@morbid98
Copy link
Author

morbid98 commented Dec 7, 2021

Any chance of a test case for this? @morbid98

I'm not familiar with Java too much, but will try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orca fails to bind artifact from json file
2 participants