fix(pipelineTriggers): change buildNumber type from int to string #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Oct 25, 2022
orca-bakery/src/test/groovy/com/netflix/spinnaker/orca/bakery/tasks/CreateBakeTaskSpec.groovy
Show resolved
Hide resolved
dbyron-sf
reviewed
Oct 25, 2022
orca-core/src/main/java/com/netflix/spinnaker/orca/pipeline/model/BuildInfo.kt
Show resolved
Hide resolved
|
@Mergifyio update |
❌ Pull request can't be updated with latest base branch changesMergify needs the author permission to update the base branch of the pull request. |
jaredstehler
force-pushed
the
build-number-tostring
branch
from
d747883
to
90975c0
Compare
dbyron-sf
reviewed
Nov 11, 2022
| @@ -112,7 +112,9 @@ public boolean tryToExtractBuildDetails(BuildInfo<?> buildInfo, Map<String, Obje | |||
| if (buildInfo == null || request == null) { | |||
| return false; | |||
| } | |||
| if (buildInfo.getUrl() != null && buildInfo.getName() != null && buildInfo.getNumber() > 0) { | |||
There was a problem hiding this comment.
Aaah, here's the place that was treating a number <= 0 as missing...
in order to support build numbers which are not strict integers (i.e. "123.1")
jaredstehler
force-pushed
the
build-number-tostring
branch
from
90975c0
to
c3eb632
Compare
|
can this be merged yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to support build numbers which are not strict integers (i.e. "123.1")
spinnaker/spinnaker#6743