fix(queue): Manual Judgment propagation (backport #4469) #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual Judgment was always propagated if the MJ stage was the first one in the pipeline, regardless of the value of `propagateAuthenticationContext`. The code for backtracking through stages to find an `AuthenticatedStage` provider would improperly return any stage that did not have an ancestor, ignoring criteria for selecting a stage that should be propagating authentication. Additionally, code in `AuthenticationAware` would mutate a `SKIPPED` MJ stage, copying the `LastModifiedDetails` value from the "real" MJ stage ancestor (or the root stage, as described above). This mutation is not necessary, and `AuthenticationAware` can just ignore it as it traverses ancestors of the current stage.
jasonmcintosh
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Judgment was always propagated if the MJ stage was the first one in the pipeline, regardless of the value of
propagateAuthenticationContext.The code for backtracking through stages to find an
AuthenticatedStageprovider would improperly return any stage that did not have an ancestor, ignoring criteria for selecting a stage that should be propagating authentication.Additionally, code in
AuthenticationAwarewould mutate aSKIPPEDMJ stage, copying theLastModifiedDetailsvalue from the "real" MJ stage ancestor (or the root stage, as described above). This mutation is not necessary, andAuthenticationAwarecan just ignore it as it traverses ancestors of the current stage.