Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let DiagnosticsReporter ensure function take only necessary type #6376

Conversation

wawel37
Copy link
Contributor

@wawel37 wawel37 commented Sep 11, 2024

related to #1445 in scarb.

This change is Reviewable

@wawel37 wawel37 changed the title Let DiagnosticsReporter ensure function take only necessary type Let DiagnosticsReporter ensure function take only necessary type Sep 11, 2024
Copy link
Collaborator

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput and @orizi)

Copy link
Collaborator

@Draggu Draggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput and @orizi)

@wawel37 wawel37 force-pushed the wawel37/diagnostics-reporter-types-changes branch from 1d4a6c7 to 9e1186b Compare September 11, 2024 09:51
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@piotmag769 piotmag769 self-requested a review September 12, 2024 12:46
Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@piotmag769 piotmag769 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into starkware-libs:main with commit c52b49d Sep 12, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants