Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: commit-check support forks #5851

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Sep 19, 2024

  1. commit-check workflow doesn't work for the forks:
    https://github.com/status-im/status-go/actions/runs/10939245256/job/30369087700?pr=5833

    As I understand correctly, one of the ways to fix this is to use pull_request_target events instead of pull_request:
    https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target

    Though I'm not sure if it works properly. For example, the check didn't appear in this PR. Neither it appeared in the fork PR I made for testing: test!: fake breaking change #5853.

    I assume that we have to merge it first to work, but I am very unsure if I'm doing the right thing.
    Please let me know what you think.

  2. Also added some more event types for trigger.

    • reopened (obvious reason)
    • labeled and unlabeled - to prevent removing breaking change label where it's required.

@status-im-auto
Copy link
Member

status-im-auto commented Sep 19, 2024

Jenkins Builds

Click to see older builds (9)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f6ae2ec #1 2024-09-19 10:39:53 ~2 min tests-rpc 📄log
✔️ f6ae2ec #1 2024-09-19 10:41:15 ~3 min linux 📦zip
✔️ f6ae2ec #1 2024-09-19 10:42:49 ~5 min android 📦aar
✔️ f6ae2ec #1 2024-09-19 10:44:47 ~7 min ios 📦zip
✔️ f6ae2ec #1 2024-09-19 11:09:32 ~32 min tests 📄log
✔️ 5fbf678 #2 2024-09-19 10:57:07 ~2 min tests-rpc 📄log
✔️ 5fbf678 #2 2024-09-19 10:58:26 ~3 min linux 📦zip
✔️ 5fbf678 #2 2024-09-19 10:59:29 ~5 min ios 📦zip
✔️ 5fbf678 #2 2024-09-19 10:59:53 ~5 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 21193c9 #3 2024-09-19 11:05:09 ~2 min tests-rpc 📄log
✔️ 21193c9 #3 2024-09-19 11:06:36 ~3 min linux 📦zip
✔️ 21193c9 #3 2024-09-19 11:07:33 ~4 min ios 📦zip
✔️ 21193c9 #3 2024-09-19 11:07:58 ~5 min android 📦aar
✔️ 21193c9 #2 2024-09-19 11:41:45 ~32 min tests 📄log
✔️ e99a905 #4 2024-09-19 11:16:15 ~1 min tests-rpc 📄log
✔️ e99a905 #4 2024-09-19 11:19:16 ~4 min linux 📦zip
✔️ e99a905 #4 2024-09-19 11:20:24 ~5 min ios 📦zip
✔️ e99a905 #4 2024-09-19 11:20:32 ~5 min android 📦aar
✔️ e99a905 #3 2024-09-19 12:12:31 ~30 min tests 📄log

@igor-sirotin igor-sirotin marked this pull request as ready for review September 19, 2024 11:25
@igor-sirotin igor-sirotin requested a review from a team September 19, 2024 11:26
@igor-sirotin
Copy link
Collaborator Author

@status-im/devops please let me know if I'm doing the right thing here

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants