fix_: commit-check support forks #5851
Open
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-check workflow doesn't work for the forks:
https://github.com/status-im/status-go/actions/runs/10939245256/job/30369087700?pr=5833
As I understand correctly, one of the ways to fix this is to use
pull_request_target
events instead ofpull_request
:https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target
Though I'm not sure if it works properly. For example, the check didn't appear in this PR. Neither it appeared in the fork PR I made for testing: test!: fake breaking change #5853.
I assume that we have to merge it first to work, but I am very unsure if I'm doing the right thing.
Please let me know what you think.
Also added some more event types for trigger.
reopened
(obvious reason)labeled
andunlabeled
- to prevent removingbreaking change
label where it's required.