Add cable_ready.integration_test_request_encoding initializer
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This has been adapted from https://github.com/hotwired/turbo-rails/blob/9b17a3be3705786d72c3ae77fde5a9b3006555d7/lib/turbo/engine.rb#L119 * In order to streamline development, Rails integration tests should be able to support `as: :cable_ready` to test Cable Ready responses * This is done by setting up a new request encoding that ActionDispatch's integration tests can use. In this case, the encoder is barebones and is largely focused on streamlining how the request `Accept` headers are setup
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
marcoroth
reviewed
Sep 12, 2024
| # Support `as: :cable_ready`. Public `register_encoder` API is a little too strict. | ||
| class ActionDispatch::RequestEncoder | ||
| class CableReadyStreamEncoder < IdentityEncoder | ||
| header = [ Mime[:cable_ready], Mime[:html] ].join(",") |
There was a problem hiding this comment.
Hey @tcannonfodder, thanks for this pull request. Should this be :json instead of :html, since the MIME-Type is text/vnd.cable-ready.json:
Suggested change
| header = [ Mime[:cable_ready], Mime[:html] ].join(",") | |
| header = [ Mime[:cable_ready], Mime[:json ].join(",") |
There was a problem hiding this comment.
@marcoroth yeah, that sounds right to me. There's a syntax error in your suggestion though, so it's this:
Suggested change
| header = [ Mime[:cable_ready], Mime[:html] ].join(",") | |
| header = [ Mime[:cable_ready], Mime[:json] ].join(",") |
There was a problem hiding this comment.
Yes, you are totally @kaspth! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Enhancement
Description
as: :cable_readyto test Cable Ready responsesAcceptheaders are setupWhy should this be added
This makes it easier for folks to write tests for their CableReady actions, making the gem fit into the larger ecosystem
Checklist