Release: Prerelease 8.4.0-alpha.1 #29118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Addon-Interactions: Use ansi-to-html for colored test errors
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
| @@ -135,7 +136,7 @@ export const Exception = ({ exception }: { exception: Call['exception'] }) => { | |||
| const more = paragraphs.length > 1; | |||
| return ( | |||
| <RowMessage> | |||
| <pre>{paragraphs[0]}</pre> | |||
| <pre dangerouslySetInnerHTML={{ __html: filter.toHtml(paragraphs[0]) }}></pre> | |||
There was a problem hiding this comment.
style: Use of dangerouslySetInnerHTML could pose a security risk if the input is not properly sanitized
Comment on lines
+137
to
+139
| dangerouslySetInnerHTML={{ | ||
| __html: filter.toHtml(printSerializedError(caughtException)), | ||
| }} |
There was a problem hiding this comment.
style: Use of dangerouslySetInnerHTML might pose security risks if the input is not properly sanitized
Comment on lines
+137
to
+140
| <span | ||
| key={line + index} | ||
| dangerouslySetInnerHTML={{ __html: filter.toHtml(line) }} | ||
| ></span>, |
There was a problem hiding this comment.
logic: Using dangerouslySetInnerHTML can be a security risk if the input is not properly sanitized. Ensure that the filter.toHtml() method properly escapes any potentially malicious content.
VS Code complains about not being able to find Node types, but building the package works. Need to investigate.
VS Code complains about not being able to find Node types, but building the package works. Need to investigate.
Next.js: Upgrade sass-loader from ^12 to ^13
Angular: Fix sourceDecorator to apply excludeDecorators flag
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
5bd0c95
to
5bbaad1
Compare
…jsdoc-type-pratt-parser Core: Do not prebundle jsdoc-type-pratt-parser
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
5bbaad1
to
7d1ba90
Compare
…better-opn Core: Do not prebundle better-opn
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
7d1ba90
to
c8cb610
Compare
Since v10.24.0, Preact pretends to be React version 18.3.1 instead of 17.0.2. This change has caused an assertion failure in one of our E2E tests where we have assumed to see React 17.0.2 printed in one of our stories.
…preact Preact: Fix E2E test
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
c8cb610
to
f19d4cd
Compare
…tall-installation
Core: Replace `fs-extra` with the native APIs
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
f19d4cd
to
f760f5a
Compare
…installation CLI: Fix skip-install for stable latest releases
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
f760f5a
to
7d463e8
Compare
…er-addition-to-package-json Core: Do not add packageManager field to package.json during `storybook dev`
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
7d463e8
to
91d6ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.4.0-alpha.0to8.4.0-alpha.1.Once this pull request is merged, it will trigger a new release of version
8.4.0-alpha.1.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:storybook dev#29152 (will also be patched)fs-extrawith the native APIs #29126If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.0-alpha.1
storybook dev- #29152, thanks @valentinpalkovic!fs-extrawith the native APIs - #29126, thanks @ziebam!