Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade expo to 51 #769

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Upgrade expo to 51 #769

merged 7 commits into from
Aug 7, 2024

Conversation

ianlin-bbpos
Copy link
Collaborator

Summary

Upgrade Expo to 51 for example-app.

Motivation

Upgrade Expo to 51 for example-app for troubleshooting the issue #744

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@@ -133,6 +133,7 @@ workflows:
inputs:
- content: |-
cd example-app/ios
pod update hermes-engine --no-repo-update
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bric-stripe, trouble you again😬. I'm working on upgrading expo and met a issue of building on ios. Base on the latest expo, I also upgraded the dependencies as expo requests, including react-native with the hermes-engine. first error came as
image
then I added this line 'pod update hermes-engine --no-repo-update' to fix. but it cause current issue as
image
I've tried several way to try to fix it, like changing Podfile to set 'use_modular_headers!' or use :modular_headers => true for 'DoubleConversion' , but there is no lucky. Have you seen such a error before and had experiences to fix it ? Please take a look when you get a chance, thanks~.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: I found a workaround that set use_frameworks! :linkage => :static in Podfile, and it works.

@nazli-stripe nazli-stripe merged commit 5b875e5 into main Aug 7, 2024
3 checks passed
@nazli-stripe nazli-stripe deleted the bbpos/upgrade-expo-to-51 branch September 7, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants