Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Suggestion: useEffect の依存関係を追加 #443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[fix] Suggestion: useEffect の依存関係を追加 #443

wants to merge 1 commit into from

Conversation

honyanya
Copy link
Contributor

Changed

下記の対応を実施

React Hook useEffect has a missing dependency: 'props.result'. Either include it or remove the dependency array. If 'setApiResult' needs the current value of 'props.result', you can also switch to useReducer instead of useState and read 'props.result' in the reducer.eslintreact-hooks/exhaustive-deps

@vercel
Copy link

vercel bot commented Mar 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
tools ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 27, 2023 at 1:55PM (UTC)

@honyanya honyanya closed this Mar 27, 2023
@honyanya honyanya reopened this Mar 27, 2023
swfz
swfz reviewed Mar 31, 2023
View reviewed changes
Copy link
Owner

@swfz swfz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@honyanya ちょっとうろ覚えではあるけど、追加すると壊れるので追加していないって感じだった気がする
動作問題なかったですか？

@honyanya
Copy link
Contributor Author

honyanya commented Apr 3, 2023

軽く動作確認した感じは大丈夫そうでしたがもう少し詳細に動作確認見てみます

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swfz swfz swfz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honyanya @swfz