tdiary serverコマンドにlogオプションを追加 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
その昔、特に何も考えないで rack サーバーなら thin と trinidad でしょうということで追加した部分なので、:server グループごと消してしまってよさそうです! |
| } | ||
| TDiary::Server.run( opts ) | ||
| elsif | ||
| # --rack option | ||
| # Rack::Server reads ARGV as :config, so delete it | ||
| require 'webrick' |
There was a problem hiding this comment.
unicorn のような別の rack サーバーを使ってる時は不要だと思うので、それらがないときだけ webrick が使われるというコードだと良さそうです
There was a problem hiding this comment.
unicornで動かすときは、unicorn -> config.ru -> run TDiary::Application.new の順番で起動するため、このルートは通らないです。コマンドラインから tdiary server コマンドを起動したときだけ、 cli.rb 経由で webrick が起動します。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#397 の対応です。標準のRackサーバをwebrickにし、logオプションを追加しました。未指定時はこれまで通りに標準出力に表示します。