Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/71 add tests #75

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat/71 add tests #75

wants to merge 4 commits into from

Conversation

shentschel
Copy link
Collaborator

@shentschel shentschel commented Jun 6, 2024 •
edited
Loading

Added tests for the main public routes. I hope I did not miss one.

Stefan Jacobi added 3 commits June 6, 2024 16:11
fix(migrations): fix downing database scripts
5439f06 
* use a sql to try to parse varchar to uuid on migrating down
* fix typos in name
tests(router): test main routes
4dca698 
Closes: #71
tests(router): test main routes
12d81e7 
Closes: #71
FreddyDevelop
FreddyDevelop reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@FreddyDevelop FreddyDevelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, but please split the test file, its really big and not easy maintainable.

tests(router): add admin tests
3d2280e 
* add admin tests
* split tests in multiple files for better maintainability.

Closes: #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreddyDevelop FreddyDevelop Awaiting requested review from FreddyDevelop

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shentschel @FreddyDevelop